[Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27426


Luke Kenneth Casson Leighton <lkcl at lkcl.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33053|                            |review?
               Flag|                            |




--- Comment #1 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-07-19 13:45:49 PDT ---
Created an attachment (id=33053)
 --> (https://bugs.webkit.org/attachment.cgi?id=33053)
adds GDOMBindings

from memory, review comments regarding these files:

* why [were] #ifdef 0s added around some code?

  answer: because they might be needed for debugging purposes, just as they
might be needed in JSDOMBindings.cpp

after a few attempts to keep that code in, just in case, reviewers were so
insistent that i decided it wasn't worth messing around with, and removed them.

* why are the headers not in strict alphabetical order?

 answer: whereas in the JS Bindings, the functions are split across several
files (toJS), it was decided to simply cut/paste the copies of the functions
from which the toGDOM versions are derived into one single file.  the headers
were therefore grouped together from the places from whence they came, and
"s/JS/GDOM/g" was then applied.  it _may_ make sense to re-split
GDOMBinding.cpp back into separate files, which would be made all the easier by
keeping the header files grouped together.  a comment [somewhat] to this effect
has been placed at the top of the file GDOMBinding.cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.