[Webkit-unassigned] [Bug 27324] Add ENABLE_RUBY to list of build options

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 19 00:29:21 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27324


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32824|review?                     |review-
               Flag|                            |




--- Comment #3 from David Levin <levin at chromium.org>  2009-07-19 00:29:20 PDT ---
(From update of attachment 32824)
Address the following few issues and I think it will be ready to land.

Two issues:
1. You appear to be missing changes to trunk/WebCore/GNUmakefile.am and
trunk/WebCore/WebCore.vcproj/WebCoreCommon.vsprops (see
http://trac.webkit.org/changeset/46021 for example changes to these files).
2. The changelog should have the following:

  Date Name line

  Reviewed by NOBODY (OOPS!).

  >Bug Title<
  >Bug Link<

  Description of change.

a. Your change logs appears to be missing the items in ><
b. Your description line seems to need to be indented one more space.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list