[Webkit-unassigned] [Bug 25401] <use> of text not displayed unless declared after

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 18 01:52:26 PDT 2009


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
                 CC|                            |rwlbuis at gmail.com

--- Comment #4 from Rob Buis <rwlbuis at gmail.com>  2009-07-18 01:52:20 PDT ---
Hi Eric,

(In reply to comment #3)
> (From update of attachment 32278 [details])
> Isn't:
> 8     // Invalidate all SVGElementInstances associated with us
>  139     SVGElementInstance:: invalidateAllInstancesOfElement(this);
> needed in the root SVGElement childrenChanged method?  How do we handle
> updating <use> elements when other subtrees change?

I think <use> only references styled elements, so the hooks are only there, see
SVGStyledElement::childrenChanged and SVGStyledElement::svgAttributeChanged.
that childrenChanged only calls invalidateAllInstancesOfElement after parsing
is over, so that
is not enough in the use forward references to text, hence my patch overwriting
it. Can you think of scenarios/testcases where the patch fails? Any other
forward referencing cases that fail?


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list