[Webkit-unassigned] [Bug 27351] [Qt] navigator.platform returns an empty string in Symbian and in Linux platforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27351


Holger Freyther <zecke at selfish.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32911|review+                     |review-
               Flag|                            |




--- Comment #9 from Holger Freyther <zecke at selfish.org>  2009-07-17 18:00:49 PDT ---
(From update of attachment 32911)

>  
>  String NavigatorBase::platform() const
>  {
> +#if PLATFORM(LINUX)
> +    struct utsname osname;
> +    int result = uname(&osname);
> +    String platformName;
> +    if (result >= 0) {
> +        platformName = osname.sysname;
> +        platformName += " ";
> +        platformName += osname.machine;
> +    }
> +    return platformName;
> +#else
>      return WEBCORE_NAVIGATOR_PLATFORM;
> +#endif

Jan is right, we should call uname(&osname) exactly once. Yael could you post
an updated version of the patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.