[Webkit-unassigned] [Bug 27046] Implement CSSOM DocumentView.caretRangeFromPoint

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27046





--- Comment #8 from Xiaomei Ji <xji at chromium.org>  2009-07-17 12:50:36 PDT ---
> > 2. When calculating the coordinate relative to document, you are taking zoom
> > factor into consideration. Should it also take document scrolling into
> > consideration as well? Since the spec says (x, y) is coordinates in viewport.
> > Or maybe we can use coordinate relative to document and let JS do  the
> > computation.
> 
> All computation should be done relative to the viewport, so I think scrolling
> is already accounted for, though adding tests is the way to be sure.

If HitTest is done relative to viewport when the document is scrolled, the
computed range offset is shifted too (relative to viewport, not relative to the
element within the document).
I added the adjustment when I ran test. But I do not know whether zoom factor
or other part in your patch takes care of that. And you are right, adding test
is the way to be sure.

Thanks!
Xiaomei

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.