[Webkit-unassigned] [Bug 27381] WinLauncher Crash with File URLs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27381


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32960|review?                     |review+
               Flag|                            |




--- Comment #2 from Adam Roben (aroben) <aroben at apple.com>  2009-07-17 11:34:10 PDT ---
(From update of attachment 32960)
>          if (SUCCEEDED(UrlCreateFromPath(urlBStr, fileURL, &fileURLLength, 0)))
> -            urlBStr = fileURL;
> +            SysReAllocString(&urlBStr, fileURL);

It doesn't seem so great to be modifying the urlBStr parameter like this. Maybe
it would be better to put the file: URL into a separate variable? Something
like:

BSTR fileURLBstr = 0;
if (...) {
    fileURLBstr = SysAllocString(...);
    urlBStr = fileURLBstr;
}

...actual loading calls here...

if (fileURLBstr)
    SysFreeString(fileURLBstr);

But it seems OK as-is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.