[Webkit-unassigned] [Bug 25524] [Gtk] Expose the title attribute to assistive technologies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25524


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32933|review?                     |review-
               Flag|                            |




--- Comment #8 from Gustavo Noronha (kov) <gns at gnome.org>  2009-07-17 07:47:16 PDT ---
(From update of attachment 32933)
> +2009-07-17  Mario Sanchez Prada  <msanchez at igalia.com>
> +
> +	Reviewed by NOBODY (OOPS!).
> +
> +	https://bugs.webkit.org/show_bug.cgi?id=25524
> +	[Gtk] Expose the title attribute to assistive technologies
> +
> +	Expose 'alt' attribute from images as accessible name.
> +	Expose the 'title' core HTML attribute as accessible description.
> +
> +        * accessibility/AccessibilityRenderObject.cpp:
> +        (WebCore::AccessibilityRenderObject::stringValue):
> +        (WebCore::AccessibilityRenderObject::accessibilityDescription):
> +

The indentation here is completely off. You should align everything at 8 chars,
with no tabs at all.

> +        if (node && node->isHTMLElement()) {
> +            const AtomicString& alt = static_cast<HTMLElement*>(node)->getAttribute(altAttr);
> +            if (!alt.isEmpty())
> +              return alt;

Bad indentation here (2 instead of 4 spaces). If you're using Emacs you may
want to do M-x set-variable <RET> c-basic-offset <RET> 4 <RET> =)

> +    } else {
> +      Node* node = m_renderer->node();
> +      if (node && node->isHTMLElement()) {
> +        const AtomicString& title = static_cast<HTMLElement*>(node)->getAttribute(titleAttr);
> +        if (!title.isEmpty())
> +          return title;
> +      }

Bad indentation here too.

I could just fix this stuff myself, and commit, since the rest of the patch
looks good, but I'd like to have an updated patch submitted by you that I can
just apply and commit. Thanks for your work!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.