[Webkit-unassigned] [Bug 25523] [GTK] The text displayed by push buttons is not exposed to assistive technologies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25523





--- Comment #7 from Mario Sanchez Prada <msanchez at igalia.com>  2009-07-17 02:57:31 PDT ---
(In reply to comment #6)
> Hi Mario. This patch requires a ChangeLog.

Ok, I'll send a patch with the ChangeLog modified, although I'm afraid I still
could not fill myself the "Reviewed by <reviewer>" line, so I'll leave a
placeholder there.

Or is there a better way to do this? (I'm new contributing to Webkit so any tip
here would be appreciated)

> > +String RenderButton::text() const
> > +{
> > +    return m_buttonText ? m_buttonText->text() : 0;
> > +}
> > +
> 
> This can be inlined in RenderButton.h. And also, RenderButton::text() should
> return const String instead of just String.

I did it this way as that's how I've seen it's done in other places, such as
RenderMenuList.[h|cpp]. Anyway, I've no problem in implementing it as an inline
funcion in the .h file if that's ok.

I'll come up in some minutes with a new patch addressing these issues then.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.