[Webkit-unassigned] [Bug 27359] [V8] Centralize hidden property names

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27359


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32910|review?                     |review+
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2009-07-16 19:07:46 PDT ---
(From update of attachment 32910)
> Index: WebCore/bindings/v8/V8HiddenPropertyName.cpp
> +    static v8::Persistent<v8::String>* string = new v8::Persistent<v8::String>(v8::Persistent<v8::String>::New(v8::String::NewSymbol(key)));

It seems a shame to repeat "new
v8::Persistent<v8::String>(v8::Persistent<v8::String>::New(v8::String::NewSymbol(key)))"
twice already in this file.

What about a function so this line of code would look something like this 
   static v8::Persistent<v8::String>* string = createV8PeristentString(key)
?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.