[Webkit-unassigned] [Bug 25998] [GTK] Build failure: conflicting declaration 'typedef XID Cursor'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25998





--- Comment #12 from Holger Freyther <zecke at selfish.org>  2009-07-16 02:27:22 PDT ---
(In reply to comment #11)

> > Right, but it is a lot better than attempting undoing damage later.
> 
> Sorry, I didn't mean to get into an argument here. 
> 
> What specific damage do you see here?

At least some part of npapi.h believes we are supposed to use QuickDraw. This
could mean that structs like  NPWindow, NPEvent, NPRegion... could have wrong
sizes (e.g. missing a pointer we need on X11). We might be lucky and things
just work... One proper fix is to make sure that our copy of npapi.h respects
that we want to build for unix (Netscape's equivalent for using X11).





> Do you have an alternative patch

No, other patch... whenever I boot into OSX again I can come up with one, if
you are willing to wait. The patch will be along the lines of defining XP_UNIX
in the buildsystem and making sure that XP_MAC is not defined...


> > 
> > 
> > The plugin we are talking about is purely written for unix/X11 and Gtk+ does
> > not support plugins on OSX yet, and once we do we will not use the Gtk+ plugin
> > but the mac one (as it already supports the three different drawing models).
> 
> Is this available in 1.11 or just in trunk and if so where?  How is it
> configured Ideally on a Mac platform configure should detect whether gtk-x11 is
> available or not and enable the correct plugin (gtk-x11 or mac native
> if I understand correctly).
> 
> Sorry for sounding dense but I'm new to the webkit code base and am trying to
> understand.

There is no code for Gtk+ yet. If you look into WebCore/plugins/mac/ you will
see the code used by Qt to support plugins on the mac. We would use the same
code...and add #elif PLATFORM(GTK) to the nativeWindowFor and cgHandleFor
method (and others were Qt specific code is) in the PluginViewMac.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.