[Webkit-unassigned] [Bug 27337] Add a getter in MessagePortChannel for the PlatformMessagePortChannel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27337


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32843|review?                     |review-
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2009-07-16 01:46:52 PDT ---
(From update of attachment 32843)
It would be nice to mention in the bug why this is useful.

> Index: WebCore/dom/MessagePortChannel.h
> +        // Getter for m_channel.

I'd remove this comment as it doesn't really seem to add any information.

> +        PassRefPtr<PlatformMessagePortChannel> channel();

Since this method isn't really passing the ref count to the caller (it retains
the ref counted pointer), just return PlatformMessagePortChannel* (instead of a
PassRefPtr).

Also, why not just define this inline?
     return m_channel.get();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.