[Webkit-unassigned] [Bug 26988] Haiku-specific files for WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26988


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32308|review?                     |review-
               Flag|                            |




--- Comment #14 from Oliver Hunt <oliver at apple.com>  2009-07-16 00:53:48 PDT ---
(From update of attachment 32308)

> +double currentTime()
> +{
> +    struct timeval tv;
> +    struct timezone tz;
> +
> +    gettimeofday(&tv, &tz);
> +    return (double)tv.tv_sec + (double)(tv.tv_usec / 1000000.0);
Once again c++ style casts please :D

> +TranslatorDecoder::TranslatorDecoder()
> +{
> +    m_image = 0;
> +    setSize(-1,-1);
> +}
space after the ,

> +
> +bool TranslatorDecoder::isSizeAvailable() const
> +{
> +    return !(size() == IntSize(-1, -1));
> +}
Does != really not work here?

> +void TranslatorDecoder::setData(SharedBuffer* data, bool allDataReceived) 
> +{ 
> +    if(allDataReceived) {
> +        BMemoryIO io(data->data(),data->size());
> +        m_image = BTranslationUtils::GetBitmap(&io);
> +        if (m_image) {
> +            //set the image size decoded.
> +            setSize(m_image->Bounds().Width() + 1, m_image->Bounds().Height() + 1);
> +        }   
Should not have braces around a single line if :D

> +void Widget::setFrameRect(const IntRect& rect)
> +{
> +    if (!platformWidget())
> +        return;
> +
> +    if (frameRect() != rect){
Space before {

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.