[Webkit-unassigned] [Bug 26988] Haiku-specific files for WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26988


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32300|review?                     |review-
               Flag|                            |




--- Comment #8 from Oliver Hunt <oliver at apple.com>  2009-07-16 00:23:41 PDT ---
(From update of attachment 32300)

> +// extensions beyond IE's API
> +HashSet<String> ClipboardHaiku::types() const 
> +{
> +    HashSet<String> result;
> +    BMessage *data;
> +
> +    if (be_clipboard->Lock()) {
> +        if ((data = be_clipboard->Data())) {
> +            char *name;
> +            uint32 type;
> +            int32 count;
> +
> +            for (int32 i = 0;
> +                 data->GetInfo(B_ANY_TYPE, i, &name, &type, &count) == B_OK;
> +                 i++) {
> +                result.add(name);
> +            } 

This should be two lines:
               for (int32 i = 0; data->GetInfo(B_ANY_TYPE, i, &name, &type,
&count) == B_OK; i++)
                   result.add(name);

> +bool ClipboardHaiku::hasData() 
> +{
> +    bool result = false;
> +    BMessage *data;
> +
> +    if (be_clipboard->Lock()) {
> +        if ((data = be_clipboard->Data())) {
> +            result = !data->IsEmpty();
> +        }
This if-statement has a single line of code so should not have braces

Rest of the patch looks fine, but it's easier for us to do landing if we have a
set of correct patches to land

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.