[Webkit-unassigned] [Bug 27276] Some constructor objects exposed on Window have the wrong prototype chain

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27276


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32739|review?                     |review+
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2009-07-15 23:31:38 PDT ---
(From update of attachment 32739)
This looks great!  A few nits below.

> +for (property in window) {
> +    windowProperites.push(property);
> +}

No braces here.

I'm surprised we don't see a lot of junk from the testing code.  Maybe it's
better to enumerate the subframe's properties?

> +for (var x = 0; x < windowProperites.length; x++) {

Preincrement.

>  JSAudioConstructor::JSAudioConstructor(ExecState* exec, JSDOMGlobalObject* globalObject)
> -    : DOMObject(JSAudioConstructor::createStructure(exec->lexicalGlobalObject()->objectPrototype()))
> -    , m_globalObject(globalObject)
> +    : DOMObject(JSAudioConstructor::createStructure(globalObject->objectPrototype()))
> +       , m_globalObject(globalObject)

Extra space added here.

> -JSXSLTProcessorConstructor::JSXSLTProcessorConstructor(ExecState* exec)
> -    : DOMObject(JSXSLTProcessorConstructor::createStructure(exec->lexicalGlobalObject()->objectPrototype()))
> +JSXSLTProcessorConstructor::JSXSLTProcessorConstructor(ExecState* exec, JSDOMGlobalObject* globalObject)
> +    : DOMObject(JSXSLTProcessorConstructor::createStructure(globalObject->objectPrototype()))
>  {
> -    putDirect(exec->propertyNames().prototype, JSXSLTProcessorPrototype::self(exec, exec->lexicalGlobalObject()), None);
> +    putDirect(exec->propertyNames().prototype, JSXSLTProcessorPrototype::self(exec, globalObject), None);
> +    putDirect(exec->propertyNames().length, jsNumber(exec, 1), ReadOnly|DontDelete|DontEnum);

Where did this length line come from?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.