[Webkit-unassigned] [Bug 27318] Allow LocalStorage to be enabled without enabling SessionStorage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27318


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32815|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-07-15 22:00:51 PDT ---
(From update of attachment 32815)
> Index: WebCore/page/DOMWindow.cpp
> ===================================================================
> --- WebCore/page/DOMWindow.cpp	(revision 45916)
> +++ WebCore/page/DOMWindow.cpp	(working copy)
> @@ -552,6 +552,9 @@ Storage* DOMWindow::sessionStorage() con
>          return 0;
>  
>      Document* document = m_frame->document();
> +    Settings* settings = document->settings();
> +    if (!settings || !settings->sessionStorageEnabled())

You should just use page->settings() here which cannot be null.

Otherwise, looks good to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.