[Webkit-unassigned] [Bug 27241] bugzilla-tool post-commits silently fails with bad args

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 15 21:59:29 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27241


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32833|review?                     |review+
               Flag|                            |




--- Comment #5 from Eric Seidel <eric at webkit.org>  2009-07-15 21:59:29 PDT ---
(From update of attachment 32833)
You could probably re-use the self.argnames string (or wahtever it's called). 
Instead of re-typing "COMMITTISH".  

I probably woudl have written "'%s' is not a COMMITISH" as "unable to parse
commit is from %s".

What you have is fine.  Or with one or more of the modifications suggested
above.

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list