[Webkit-unassigned] [Bug 27181] StorageArea should only contain methods we intend to proxy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27181


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32828|                            |review?
               Flag|                            |




--- Comment #1 from Jeremy Orlow <jorlow at chromium.org>  2009-07-15 21:17:57 PDT ---
Created an attachment (id=32828)
 --> (https://bugs.webkit.org/attachment.cgi?id=32828)
v1

StorageArea should only contain methods we intend to proxy.
https://bugs.webkit.org/show_bug.cgi?id=27181

Right now, StorageAreaSync takes in a StorageArea* and calls methods
like importItem.  Really, StorageAreaSync should be operating directly
on StorageAreaImpl* and those methods should be removed from StorageArea
since StorageAreaSync should never be attached to anything other than a
StorageAreaImpl.
This was pointed out in the review for
https://bugs.webkit.org/show_bug.cgi?id=27072

Also clean up StorageNamespaceImpl to operate directly on
StorageAreaImpl.  Also, get rid of the factory for StorageArea
since nothing should ever create a StorageArea directly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.