[Webkit-unassigned] [Bug 27323] New: Better support for non-Cygwin SVN on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27323

           Summary: Better support for non-Cygwin SVN on Windows
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: pkasting at google.com
                CC: aroben at apple.com, abarth at webkit.org, sfalken at apple.com


Right now there are a few issues with using a non-cygwin SVN:
* Various shell scripts are checked out with eol-style=native rather than
eol-style=LF, confusing bash when svn doesn't interpret "native" on Windows as
"LF"
* Some prebuild steps explicitly add cygwin to the path, which means scripts
that call `svn` get the wrong SVN.

The solution to the first bullet is to change the existing eol-style on these
scripts, and change their line endings.  One concern raised on IRC is whether
Qt WebKit for Windows will still build here.  I think it should, as the problem
mentioned was for "native perl" and the proposal is to only change the shell
scripts, so I'm not too worried about this.

The solution to the second bullet is basically to find the .vsprops and .vcproj
files that do an explicit "set PATH" and change that step to:

%SystemDrive%\cygwin\bin\which.exe bash
if errorlevel 1 set PATH=%SystemDrive%\cygwin\bin;%PATH%

For people with cygwin already in their path, this doesn't modify the path. 
For people without it, this adds the default cygwin install location (just like
the existing code does); people without cygwin in their path and without it in
the default location aren't supported by either the old or new code.

I'll add more problems here as I encounter them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.