[Webkit-unassigned] [Bug 20348] Background color formatting lost on enter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20348


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32820|review?                     |review-
               Flag|                            |




--- Comment #14 from Eric Seidel <eric at webkit.org>  2009-07-15 16:59:55 PDT ---
(From update of attachment 32820)
This name is not sufficiently clear:
+static const int propertiesForEditing[] = {

What are these actually used for?

Do we have tests for both of these?
     // Properties for editing
 1472     CSSPropertyTextDecoration,
 1473     CSSPropertyBackgroundColor,
14701474 };

It seems this could break the optimization in:
handleStyleSpansBeforeInsertion
(which may already be broken)

Seems uses of this function are inconsistent in their needs.  I think this is
just a bad function which dates from before time:
(I stopped digging after http://trac.webkit.org/changeset/7314)

I think we should just deprecate this function and make a new (somewhat copied)
one which works for your uses.  All the callers of this need to change, but I'm
not gonna ask you to do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.