[Webkit-unassigned] [Bug 26915] HTML5: DOM binding of <datalist> element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26915


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32645|review?                     |review-
               Flag|                            |




--- Comment #9 from Eric Seidel <eric at webkit.org>  2009-07-15 16:14:28 PDT ---
(From update of attachment 32645)
Your ChangeLog is doubled.

Why is this right?
bool HTMLDataListElement::checkDTD(const Node* newChild)
 48 {
 49     return newChild->hasTagName(HTMLNames::optionTag) ||
HTMLElement::checkDTD(newChild);
 50 }

You should add a test to test the checkDTD code.  If you're trying to prevent
adding non-option elements then we need to test that?

Otherwise this looks fine.  r- since you're not a committer and this needs a
small update (and ideally another test).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.