[Webkit-unassigned] [Bug 27215] [QT] suppress (un)desired launcher output that can make layout test to fail with stderr

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27215





--- Comment #11 from Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org>  2009-07-15 14:18:30 PDT ---

> > +void PluginDatabase::clear()
> > +{
> > +    m_plugins.clear();
> > +    m_pluginsByPath.clear();
> > +    m_registeredMIMETypes.clear();
> > +}
> Sure, but no deletion needed?

It does the same as the remove() functions. It also doesn't delete anything.

> > +        void setPluginDirectories(const Vector<String>& directories)
> > +        {
> > +            clear();
> > +            m_pluginDirectories = directories;
> > +        }
> 
> Looks suspect as you're changing the behavior of this method.  Where is this
> method currently called from?  Any obvious side effects?

Only from the installedPlugins() function, so no.

> > +        bool m_pluginSetChanged;
> 
> Adding a member variable that is never used or initialized?

That is a leftover, thanks for spotting.

> > +void QWEBKIT_EXPORT qt_drt_overwritePluginDirectories()
> > +{
> > +    PluginDatabase *db = PluginDatabase::installedPlugins(/* populate */ false);
> 
> The decorator is in wrong place according to webkit coding style guidelines.

decorator? the /* populate */ ? Btw, this in in Qt code and should thus follow
the Qt coding style, but it might still be wrong though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.