[Webkit-unassigned] [Bug 27145] [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27145


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gns at gnome.org




--- Comment #6 from Gustavo Noronha (kov) <gns at gnome.org>  2009-07-15 08:09:37 PDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=32782)
 --> (https://bugs.webkit.org/attachment.cgi?id=32782) [details] [details]
> > updated patch
> 
> I made the updates except for the strlen -> sizeof change. May I ask why?
> Thanks.

Err... forgot to answer this one. This is more of a nit-pick. A strlen will
waste runtime - we already know the size of the string in build time, since it
is static and won't change. sizeof is compile-time, so no time wasted counting
chars.

Notice that we would have to use sizeof on the actual static string, not on the
variable. But, as I said, this is a nitpick, if you feel like using strlen,
there should be no problem, since this is not performance-critical code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.