[Webkit-unassigned] [Bug 26999] bugzilla-tool/svn-apply can't handle patches made from a non-root directory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 14 18:39:21 PDT 2009


--- Comment #13 from Joseph Pecoraro <joepeck02 at gmail.com>  2009-07-14 18:39:20 PDT ---
> The only situation where this won't work is [nested svn working dirs]
> I don't know how prevalent this use case is, and I doubt it's common
> with WebKit, so let's not worry about that for now.

I thought about this too.  But I don't even think that is realistic or would
work properly.  My only guess would be the actual Subversion team testing
Subversion =P.  But maybe it is possible and you're approach from before
(checking the URL from svn info and using that) would be more appropriate.

> >+sub chdirAndGetDifference($);
> Nit: Instead of "GetDifference", I think something like "ReturnRelativePath"
> might be more descriptive.  I can change this when I land the patch.

Sounds good.

Thanks for the review! Cheers.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list