[Webkit-unassigned] [Bug 27246] Add HTMLMediaElement::supportSave() and a HitTestResult::absoluteMediaURL() functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27246





--- Comment #4 from Brent Fulgham <bfulgham at webkit.org>  2009-07-14 16:04:02 PDT ---
This patch caused crashes in various media tests.  When making a change you
should run the corresponding tests (ideally, all tests) to ensure no problems.

The original patch had two big errors:

 851 
 852 bool HTMLMediaElement::supportsFullscreen() const
 853 {
 854     return m_player->supportsFullscreen();
 855 }
 856 
 857 bool HTMLMediaElement::supportsSave() const
 858 {
 859     return m_player->supportsSave();
 860 }

These two lines should be checking if m_player is null, as this will happen
(frequently).

A quick run of:  'run-webkit-tests media' would have shown this error on the
fourth test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.