[Webkit-unassigned] [Bug 27038] htmlediting.cpp needs more utility functions to fix the bug 26816

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27038


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32484|review?                     |review+
               Flag|                            |




--- Comment #12 from Eric Seidel <eric at webkit.org>  2009-07-14 15:03:23 PDT ---
(From update of attachment 32484)
Looks fine.

I think the intent of the old comments (that something needs fixing) is lost:
    // FIXME: This should ASSERT(node->parentNode())
 582     ASSERT(node);
 583     // FIXME: adding ASSERT(node->parentNode()); results in
editing/deleting/delete-ligature-001.html crashing
569584

No need to be const:
 595 VisiblePosition visiblePositionBeforeNode(const Node* node)

Generally we don't make RefCounted objects const, ever.  Because well...
they're refcounted. :)  You can't ref them w/ them being const.

I probably would have named the argument "range" and the returned value
"extendRange" but this is fine too:
 632 PassRefPtr<Range> extendRangeToWrappingNodes(PassRefPtr<Range>
rangeToExtend, const Range* maximumRange, const Node* rootNode)

Thanks.!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.