[Webkit-unassigned] [Bug 27145] [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27145


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32651|review?                     |review-
               Flag|                            |




--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2009-07-14 14:43:44 PDT ---
(From update of attachment 32651)
> +    const gchar* uri = webkit_web_history_item_get_uri(item);
> +    if (g_strcmp0(g_uri_parse_scheme(uri), "file") == 0) {

You are leaking the return of g_uri_parse_scheme here.

> +        static gchar* layoutTestString = g_strdup("/LayoutTests/");
> +        static gchar* fileTestString = g_strdup("(file test):");

These are also leaked. There should be no need to g_strdup here. Just use the
static strings instead?

> +        result = g_string_append(result, pos + strlen(layoutTestString));

I'd suggest using sizeof("/LayoutTests/") instead of strlen.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.