[Webkit-unassigned] [Bug 25889] [GTK] scrollbar policy for main frame is not implementable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25889





--- Comment #39 from Gustavo Noronha (kov) <gns at gnome.org>  2009-07-14 03:54:18 PDT ---
(In reply to comment #38)
> (From update of attachment 32028 [details])
> > +        (WebCore::ScrollView::setScrollbarModes):
> > +>>>>>>> report scrollbar policy:WebCore/ChangeLog
> 
> Something went wrong here.

/me hates ChangeLogs

> > +    GtkWidget* parent = gtk_widget_get_parent(GTK_WIDGET(webView));
> > +    if (!parent || !GTK_IS_SCROLLED_WINDOW(parent))
> > +        return;
> 
> Should this be an &&?

No. We want to return early in the case where we have no parent, or in the case
we have a parent, and it is not a scrolled window.

> > +    /* Never */
> 
> Never?

Those are the names of the scrolled window policies - never display scrollbars,
in this case. I guess I can be more descriptive.

> > +     * Determines the current policy for the horizontal scrollbar of
> > +     * the frame. For the main frame, make sure to set the same policy
> > +     * on the scrollable widget containing the #WebKitWebView, unless
> > +     * you know what you are doing.
> 
> What happens if they don't set the same policy in the widget containing the
> WebView? I think it should mention it here too.

It depends on if/how web applications code work. If, say, a hackish code
depends on the visible area being made smaller by adding a scrollbar, for some
reason, it will break if the scrollbar does not appear, making the visible area
smaller. I am not sure adding more info here will help makes this any clearer,
but I'm up for suggestions.

> The rest looks fine. I'll let Holger do the r+ as he's more familiar with it
> (and it's in his todo list :)

Cool. Need to track him, and make this not slip one more release =P.

http://bugzilla.gnome.org/show_bug.cgi?id=588130 <= =)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.