[Webkit-unassigned] [Bug 27154] useless null-check statement in visible_units.cpp at logicalStartOfLine

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27154





--- Comment #5 from Ryosuke Niwa <ryosuke.niwa at gmail.com>  2009-07-13 19:35:25 PDT ---
(In reply to comment #2)
> Hmm strange.  Does logicalEndOfLine have this problem as well?
> 
> Justin

logicalEndOfLine is slightly better:

    VisiblePosition visPos = logicalEndPositionForLine(c);

    // Make sure the end of line is at the same line as the given input
position. For a wrapping line, the logical end
    // position for the not-last-2-lines might incorrectly hand back the
logical beginning of the next line. 
    // For example, <div contenteditable dir="rtl"
style="line-break:before-white-space">abcdefg abcdefg abcdefg
    // a abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg abcdefg
abcdefg abcdefg </div>
    // In this case, use the previous position of the computed logical end
position.
    if (!inSameLogicalLine(c, visPos))
        visPos = visPos.previous();

    return c.honorEditableBoundaryAtOrBefore(visPos);

But logicalEndPositionForLine isn't used anywhere else either.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.