[Webkit-unassigned] [Bug 24187] RTL: tooltip does not get its directionality from its element's directionality

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24187


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31953|review?                     |review+
               Flag|                            |




--- Comment #16 from Darin Adler <darin at apple.com>  2009-07-13 16:50:25 PDT ---
(From update of attachment 31953)
> +    RenderObject* renderer = m_innerNonSharedNode->renderer();
> +    if (renderer)
> +        dir = renderer->style()->direction();

Could have defined the variable inside the if statement.

> +                RenderObject* renderer = titleNode->renderer();
> +                if (renderer)
> +                    dir = renderer->style()->direction();

Ditto.

> +    }
> +    else if (isEqual(WebElementTitleKey, key)) {

In WebKit coding style, the else goes on the same line as the brace.

> +void WebChromeClient::setToolTip(const String& toolTip, TextDirection /* dir */)

We normally omit the name entirely rather than having it included but commented
out.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.