[Webkit-unassigned] [Bug 27235] apply styles to data displayed in the scripts variable lists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27235





--- Comment #1 from Patrick Mueller <pmuellr at yahoo.com>  2009-07-13 13:29:25 PDT ---
Created an attachment (id=32675)
 --> (https://bugs.webkit.org/attachment.cgi?id=32675)
experimental patch - not intended for production

Patch that supports some amount of styling of data, just to see how this would
work.  Raises questions:

- it would be nice, in theory, to reuse the same styles used in the source
frame - webkit-javascript-string, et al.  However, these aren't available in
inspector.css, but are instead hammered into the source frame in the
SourceFrame.js file.  I haven't investigated why the styles are done this way,
but it makes reuse harder.

- reuse today may not be practical anyway; the blue for numbers isn't blue
enough to distinguish from black; the purplish keyword color that could be used
for keywords like null is already used as the style for the variable names,
etc.  Should these be harmonized somehow?  Perhaps the purplish color for the
variable names in the existing variable list could be changed to a greenish
color, for instance.  

- the way that I added the function to stylize was to augment Object.describe()
to take a third parameter which will return a string of HTML instead of just
plain text.  Which means that all the text needs to be HTML escaped.  Which is
overkill, performance-wise.  Maybe it's not an issue, performance-wise; it does
make the code ickier - if left this way functionally, Object.describe() could
probably be cleaned up a bit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.