[Webkit-unassigned] [Bug 25884] WebKit needs a style linting tool

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25884





--- Comment #32 from Shinichiro Hamaji <hamaji at chromium.org>  2009-07-13 07:17:40 PDT ---
> First, I know it was suggested that this tool be able to automatically fix
> errors but this patch is huge without that support.  It would be nice to do the
> review without that added support and then add it.  I have two reasons for
> this:
>    1. It is less to review in this initial pass.
>    2. I would like to be able to review that code in more detail since it is
> pretty new and untested (unlike the rest of the code which mostly has been in
> use already).
> 
> Secondly, WebKit python code is following the python coding style
> (http://www.python.org/dev/peps/pep-0008/, which is different from Google's). 
> The main differences are 
>    1. indent code by 4 space not 2. Fortunately, you can use
> http://svn.python.org/projects/python/trunk/Tools/scripts/reindent.py to
> automatically do this for you.
>    2. Function/Method names should be lower_case_with_underscores as opposed to
> CamelCase

Agreed. I also reverted the change for supporting lint for patch as this
feature is also new and needs detailed review. If you want to have one more
step, I may be able to split this patch into 1. just adding cpplint with
webkit's python style and 2. modifying cpplint so that it supports webkit's c++
style instead of python. Please let me know if you want this step.

> I didn't do an in depth review at this point, but I left a few comments on
> things I noticed during a quick look.

Thanks for the review! I've fixed the issues you mentioned. I also fixed the
style of python. Hmm... fixing CamelCase wasn't fun :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.