[Webkit-unassigned] [Bug 27011] [Gtk] Implement support for get_index_in_parent
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jul 11 12:17:04 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=27011
--- Comment #5 from Xan Lopez <xan.lopez at gmail.com> 2009-07-11 12:17:04 PDT ---
(In reply to comment #4)
> (From update of attachment 32456 [details])
> > - // FIXME: This needs to be implemented.
> > - notImplemented();
> > + AccessibilityObject* coreObject = core(object);
> > + AccessibilityObject* parent = coreObject->parentObject();
> > +
> > + g_return_val_if_fail (parent, 0);
>
> Just a nit: this needs to be in "if" since we're dealing with WebCore objects.
I don't understand what you mean here.
>
> I'll clear the review flag for now until we sort out Joanmarie's findings.
Joannie, do you think it's better to land this as it is and fix things
incrementally or would be this patch worse than no implementation?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list