[Webkit-unassigned] [Bug 26999] bugzilla-tool/svn-apply can't handle patches made from a non-root directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26999





--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-07-11 11:28:37 PDT ---
These seems like an OK idea to me.

# Change to WebKit dir and get the difference from the current dir
 458 sub chdirWebKitAndGetPrefix
 459 {
 460     my $before = File::Spec->rel2abs( File::Spec->curdir() );
 461     chdirWebKit();
 462     my $after = File::Spec->rel2abs( File::Spec->curdir() );
 463     $before =~ s/^$after\/?//;
 464     return $before if $before eq '';    # Already at WebKit dir
 465     $before .= '/' if $before !~ /\/$/; # Prefix needs a trailing '/'
 466     return $before;
 467 }

seems a little complicated and hard to read...  Shouldn't we just have a
command in wkdirs.pm like:
git rev-parse --show-prefix
?

Which is then separate from the chdirWebKit command?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.