[Webkit-unassigned] [Bug 27170] drawImage method of HTMLCanvasElement to accept HTMLVideoElement as argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27170


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32603|review?(dglazkov at chromium.o |review-
               Flag|rg)                         |




--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-07-10 21:54:24 PDT ---
(From update of attachment 32603)
> +            if (ec != 0) {
> +                V8Proxy::setDOMException(ec);
> +                return notHandledByInterceptor();
> +            }

This probably should be

if (ec)
   return throwError(ec);

> +            if (ec != 0) {
> +                V8Proxy::setDOMException(ec);
> +                return notHandledByInterceptor();
> +            }

Ditto.

> +            break;
> +        default:
> +            V8Proxy::throwError(V8Proxy::SyntaxError, "drawImage: Invalid number of arguments");
> +            return v8::Undefined();

return throwError(V8Proxy::SyntaxError, "drawImage: Invalid number of
arguments");

> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 45742)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,12 @@
> +2009-07-07  Alpha Lam  <hclam at chromium.org>
> +
> +        Reviewed by NOBODY(OOPS!).
> +
> +        Changed CanvasRenderingContext2DDrawImage to accept HTMLVideoElement
> +        as a parameter of drawImage of HTMLCanvasElement.
> +


Wrong ChangeLog? Should be WebCore/ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.