[Webkit-unassigned] [Bug 25316] Outdenting a line inside a blockquote tag does nothing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 10 20:20:12 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25316





--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-07-10 20:20:12 PDT ---
(From update of attachment 32601)
Why is it OK to remove the ! check here?
-                if (isIndentBlockquote(splitPointParent)
-                    && !isIndentBlockquote(splitPoint)
+                if (splitPointParent->hasTagName(blockquoteTag)

Style:
+    else
+        splitElement(static_cast<Element*>(enclosingNode),
visibleStartOfParagraph.deepEquivalent().node());
+        // We split the blockquote at where we start outdenting.
comment would go before the splt, and the whole thing would be in { }

In general this looks fine.  You're a committer now, so you could just commit
this with edits, but I'd liek to see your answer to the first question before I
r+

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list