[Webkit-unassigned] [Bug 27167] bugzilla-tool: hide help for unsupported commands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27167


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32596|review?                     |review-
               Flag|                            |




--- Comment #1 from Eric Seidel <eric at webkit.org>  2009-07-10 17:59:26 PDT ---
(From update of attachment 32596)
I think this is great, except I would have defaulted "requires_local_commits"
to False, and made it a parameter to the Command constructor (__init__), then
you only need to change about 4 lines of code, instead of all the ones you did
here.

I guess I should r- this since I wouldn't recommend committing as-is, but in
general I think this feature is great!  I would have just used a slightly
different python approach.

basically now:

Command.__init__(self, ..., requires_local_commits=False)

and the few commands which do, call:

        Command.__init__(self, 'r+\'d patches on a bug', 'BUGID',
requires_local_commits=True)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.