[Webkit-unassigned] [Bug 25316] Outdenting a line inside a blockquote tag does nothing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25316


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32540|review?                     |review-
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2009-07-10 17:54:04 PDT ---
(From update of attachment 32540)
I think we should remove this function:
6060 static bool isIndentBlockquote(const Node* node)

and just use tag-based detection of blockquotes like was the case pre-r17143

Why is:
LayoutTests/platform/mac/editing/execCommand/outdent-selection-expected.txt
changing?  Please explain in your ChagneLog.

Please remove boilerplate from your ChangeLogs:
         DETAILED DESCRIPTION OF THE CHANGES GOES HERE. (OOPS!) SEE:
 9         http://webkit.org/coding/contributing.html FOR MORE INFORMATION

You soudl explain all your added tests and changes to tests in your ChangeLogs.

Please explain this change:
     if (enclosingBlockFlow != enclosingNode)
275          splitBlockquoteNode =
splitTreeToNode(enclosingBlockFlowElement(visibleStartOfParagraph),
enclosingNode, true);
 271         splitBlockquoteNode = splitTreeToNode(enclosingBlockFlow,
enclosingNode, true);
 272     else {
 273         splitElement(static_cast<Element*>(enclosingBlockFlow),
visibleStartOfParagraph.deepEquivalent().node());
 274         splitBlockquoteNode = enclosingBlockFlow;
 275     }
in your ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.