[Webkit-unassigned] [Bug 27167] New: <http://webkit.org/bugs/BUGID> bugzilla-tool: hide help for unsupported commands
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 10 17:51:40 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=27167
Summary: <http://webkit.org/bugs/BUGID> bugzilla-tool: hide
help for unsupported commands
Product: WebKit
Version: 528+ (Nightly build)
Platform: Other
OS/Version: Mac OS X 10.5
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: ddkilzer at webkit.org
CC: eric at webkit.org, mjs at apple.com, sam at webkit.org
David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #32596| |review?
Flag| |
Created an attachment (id=32596)
--> (https://bugs.webkit.org/attachment.cgi?id=32596)
Patch v1
Reviewed by NOBODY (OOPS!).
When bugzilla-tool -h|--help is invoked in an svn working
directory, don't print help for commands that are only supported
on git working directories.
* Scripts/bugzilla-tool:
(Command.requires_local_commits): Added. Must be implemented by
all subclasses.
(BugsInCommitQueue.requires_local_commits): Added.
(PatchesInCommitQueue.requires_local_commits): Added.
(ReviewedPatchesOnBug.requires_local_commits): Added.
(ApplyPatchesFromBug.requires_local_commits): Added.
(LandAndUpdateBug.requires_local_commits): Added.
(LandPatchesFromBugs.requires_local_commits): Added.
(CommitMessageForCurrentDiff.requires_local_commits): Added.
(ObsoleteAttachmentsOnBug.requires_local_commits): Added.
(PostDiffAsPatchToBug.requires_local_commits): Added.
(PostCommitsAsPatchesToBug.execute): Removed
SCM.supports_local_commits() check since this is now handled by
BugzillaTool.main().
(PostCommitsAsPatchesToBug.requires_local_commits): Added.
(BugzillaTool.commands_usage): Don't print help for commands if
they require local commits and the current SCM doesn't support
them.
(BugzillaTool.main): If command_object requires local commits
and the current SCM doesn't, exit with an error message.
---
2 files changed, 82 insertions(+), 7 deletions(-)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list