[Webkit-unassigned] [Bug 27028] [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27028


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32560|review?                     |review-
               Flag|                            |




--- Comment #12 from Jan Alonzo <jmalonzo at gmail.com>  2009-07-10 17:04:47 PDT ---
(From update of attachment 32560)
> Index: WebCore/platform/Pasteboard.h
> ===================================================================
> --- WebCore/platform/Pasteboard.h	(revision 45707)
> +++ WebCore/platform/Pasteboard.h	(working copy)
> @@ -102,6 +102,7 @@ public:
>  
>  #if PLATFORM(GTK)
>      void setHelper(PasteboardHelper*);
> +    PasteboardHelper* m_helper;
>  #endif

Is there any reason for this change?

> -    if ((gint)info == WEBKIT_WEB_VIEW_TARGET_INFO_HTML) {
> +    if ((gint)info == Pasteboard::generalPasteboard()->m_helper->getWebViewTargetInfoHtml()) {

I think calling generalPasteboard() is unnecessary here.

> +    virtual gint getWebViewTargetInfoHtml() const = 0;

What's this for?

Looks fine otherwise. r- for now as the patch needs to be revised.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.