[Webkit-unassigned] [Bug 27136] [Qt] Webkit hangs when executing an infinite JavaScript loop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27136





--- Comment #7 from Holger Freyther <zecke at selfish.org>  2009-07-10 14:44:23 PDT ---
(From update of attachment 32576)
+ JSTestPage(QObject* parent = 0) : QWebPage(parent) {}

one style comment, could move the initializer list to the next line in
accordance with the style guidelines?


> +public slots:

please make that public Q_SLOTS... the reason is that it could work with boost
and other things.

>  /*!
> +    This function is called when a JavaScript program is running for a long period of time.
> +
> +    If the user wanted to stop the JavaScript the implementation should return true; otherwise false.
> +
> +    The default implementation executes the query using QMessageBox::information with QMessageBox::Yes and QMessageBox::No buttons.



We need to add a @since 4.6 tag to the documentation. And please add some
comments to make that virtual in the future? basically it is r=me when you
change the two when landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.