[Webkit-unassigned] [Bug 22784] Home and End buttons do not do anything in drop down lists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22784


Jens Alfke <snej at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |snej at google.com




--- Comment #4 from Jens Alfke <snej at google.com>  2009-07-10 13:56:40 PDT ---
Here's a fix. 

* I added support for "Home", "End", "PgUp" and "PgDown" keys. To reduce
duplicated code between all these cases (and the arrow keys) I factored out the
list-traversal into a new static function.

* This bug affects non-Mac platforms. I found that it also affects the Mac
version of Chromium, because in Chromium PLATFORM(MAC) has to be false. But Mac
Chromium should follow the Mac HI guidelines the way Safari does, so I changed
the tests for defining ARROW_KEYS_POP_MENU so that it will also be true in Mac
Chromium. The logic gets a little weird, but I did what I could with the
existing platform flags. Maybe we need a new flag
PLATFORM(MAC_INCLUDING_CHROMIUM) ;-)

N.b. this is also being tracked as
http://code.google.com/p/chromium/issues/detail?id=4576

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.