[Webkit-unassigned] [Bug 27154] New: useless null-check statement in visible_units.cpp at logicalStartOfLine

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27154

           Summary: useless null-check statement in
                    visible_units.cpp at logicalStartOfLine
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tonikitoo at gmail.com


quoted code below and bug summary are self explanatory. 


(...)
VisiblePosition logicalStartOfLine(const VisiblePosition& c)
{
   VisiblePosition visPos = logicalStartPositionForLine(c);

   if (visPos.isNull())
       return c.honorEditableBoundaryAtOrAfter(visPos);

   return c.honorEditableBoundaryAtOrAfter(visPos);
}
(...)


honorEditableBoundaryAtOrAfter is called regardless the null check and possibly
(wrongly) twice

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.