[Webkit-unassigned] [Bug 27136] [Qt] Webkit hangs when executing an infinite JavaScript loop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27136


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32568|review?                     |review-
               Flag|                            |




--- Comment #5 from Simon Hausmann <hausmann at webkit.org>  2009-07-10 12:08:50 PDT ---
(From update of attachment 32568)
> Index: WebKit/qt/WebCoreSupport/ChromeClientQt.cpp
> ===================================================================
> --- WebKit/qt/WebCoreSupport/ChromeClientQt.cpp	(revision 45709)
> +++ WebKit/qt/WebCoreSupport/ChromeClientQt.cpp	(working copy)
> @@ -288,8 +288,7 @@
>  
>  bool ChromeClientQt::shouldInterruptJavaScript()
>  {
> -    notImplemented();
> -    return false;
> +    return QMetaObject::invokeMethod(m_webPage, "shouldInterruptJavaScript", Qt::DirectConnection);

I don't think this is correct, invokeMethod returns a boolean indicating
whether the function could be called or not, but the return value itself is
placed in the fourth argument of invokeMethod.

Also a unit test would be good for this :)

An alternate solution would be to use QWebPage::supportsExtension and
QWebPage::extension. Holger, do you have any preference?





I

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.