[Webkit-unassigned] [Bug 27119] bugzilla-tool: Add create-bug command

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27119





--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-07-09 23:25:20 PDT ---
(From update of attachment 32518)
I think it's entirely reasonable that the first run of create-bug works only
with git. :)  Since at least 2 of the 3 known users of bugzilla-tool are git
users. :)

maybe this would be "bug-from-commits" and "bug-from-diff" is the one svn users
would use.  It's possible we could wrap them both into a single command,
although currently post-diff and post-commits are separate because git users
(at least myself) use both at different times.  post-diff is the only one which
svn users use equivalently bug-from-diff would be for svn users so they don't
have to create a patch file.

I really like the --cc option.  "gcl upload" (google's equivalent command) has
a -r option to do that which is similarly awesome!

It seems we should name the option "COMMIT" instead of COMMITISH if only one
commit is supported?

I thikn this should be in its own function:
480         commit_lines = [re.sub('^ {0,8}', '', line, 1) for line in
commit_message.splitlines()]
 481 
 482         bug_title = commit_lines[0]
 483         comment_text = "\n".join(commit_lines[1:])
 484         comment_text += "\n---\n"
 485         comment_text +=
tool.scm().files_changed_summary_for_commit(commit_id)

(title, description) = title_and_description_for_bug(commit_text)
 maybe?

It seems this belongs in a local: (since you type it out twice)
self.browser.find_control('component').items

Aren't bug descriptions required by bugzilla?

I would probably break the create_bug function up into smaller pieces still.  I
tend to be alergic to functions longer than about 30 lines. ;)

In general this looks great though!

So I'm not going to reverse Sam's review, but I don't think SVN support needs
to be required in the first patch.  Certainly SVN support should follow, but
bugzilla-tool hasn't even been announced on webkit-dev yet, so I don't really
view it as a critical project infrastructure requiring of SVN support.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.