[Webkit-unassigned] [Bug 27133] [Chromium] Upstream RGBColor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 9 20:44:45 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27133


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32538|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-07-09 20:44:44 PDT ---
(From update of attachment 32538)
> Index: WebCore/bindings/v8/RGBColor.cpp
...
> +    unsigned int value = (m_rgbColor >> 16) & 0xFF;
> +    return CSSPrimitiveValue::create(value, CSSPrimitiveValue::CSS_NUMBER);

nit: i think the prevailing style in webkit is to just use "unsigned" instead
of
"unsigned int"

otherwise, R=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list