[Webkit-unassigned] [Bug 26987] Add fast case for Math.floor(a / b) expressions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26987


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32298|review?                     |review-
               Flag|                            |




--- Comment #4 from Oliver Hunt <oliver at apple.com>  2009-07-09 20:28:57 PDT ---
(From update of attachment 32298)
I think the complexity of this patch isn't balanced performance gain.  I
recognise that we need to come up with a solution for the problem of the simple
builtin function, but i don't believe lexical specialisation is the solution. 
It works for call/apply but they have a *huge* overhead on many levels and
aren't cached in js, whereas things like the builtin Math functions (and also a
number of other builtin functions) are cached in ways that defeat lexical
caching, especially in the fast case, and the quantity of calls is likely to be
much larger than that of call and apply.

Just to make it clear, i do believe we want to improve performance of builtins,
i just don't believe lexical caching is the solution.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.