[Webkit-unassigned] [Bug 27114] bugzilla-tool: Parse short bug URL from commit log messages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27114





--- Comment #8 from Eric Seidel <eric at webkit.org>  2009-07-09 19:50:31 PDT ---
(In reply to comment #6)
> (In reply to comment #5)
> > It appears as though you still commit manually.  I'm wondering if there is
> > something we should do to fix bzt land-diff for you?
> > bzt land-commits might work as well (although it doesnt' know how to fix up
> > ChangeLogs for you).
> 
> The "land-commits" command doesn't exit currently.  I'm actually working on an
> implementation now.

Oh yeah.  Sorry, forget which ideas got finished and which didnt...

> For patches that I write, I have a different workflow than simply downloading
> patches from bugs and applying them.  I'm working on updating bugzilla-tool as
> I go--I can't fix it all in one commit, or I'll be asked to break it into
> pieces.  :)

Yup. :)  As I noted above, it wasn't really designed for committers originally.
 It was designed to be run from a cron job as a commit-bot.

> I want my workflow to work like this (suggestions welcome for improvement):
> 
> 1. Branch master.
> 2. Write the patch.
> 3. Run prepare-ChangeLog.
>   * prepare-ChangeLog should add "<http://webkit.org/b/BUGID>" to description
> line, with "BUGID" to be replaced later.
> 4. Commit the result to the local branch.
> 5. Run bugzilla-tool create-bug branch-name.
> 6. [Optional] Update local commit as needed from review.
> 7. [Optional] Repost patch using bugzilla-tool post-commit branch-name.
> 8. Run bugzilla-tool land-commits -b NNNNN branch-name.
>   * It should use the existing commit log message from git.
>   * It should replace the "BUGID" text in both the commit log message and each
> ChangeLog.
>   * It should replace the reviewer ("NOBODY (OOPS!)") text in both the commit
> log message and each ChangeLog.
>   * It should close the bug like "land-diff" does when finished.

Seems fine.

Ideally bugzilla-tool will also be fixed for git users to instead of enforcing
a clean tree, instead just stash local changes and make a new trunk branch when
doing things like land-patches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.