[Webkit-unassigned] [Bug 27128] Make Widget Ref-Counted.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 9 14:59:39 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27128


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32533|review?                     |review+
               Flag|                            |




--- Comment #6 from Dave Hyatt <hyatt at apple.com>  2009-07-09 14:59:39 PDT ---
(From update of attachment 32533)
Typo in ChangeLog:

"setWidget() now takes a PassRefPtr. Also eemoved the manual ref of "

"eemoved" should be "removed".

ScrollView::platformAddChild never takes ownership of the Widget, so I don't
think you needed to change any of those implementations. Those should just be
platformAddChild(Widget*) still.  You can undo that change and avoid having to
touch a bunch of ScrollView port files.

With those changes, r=me!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list