[Webkit-unassigned] [Bug 20625] ConsoleMessage should have a "type" attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20625





--- Comment #6 from Keishi Hattori <casey.hattori at gmail.com>  2009-07-09 14:43:19 PDT ---
(In reply to comment #5)
> (From update of attachment 32504 [details])
> 
> > -            case WebInspector.ConsoleMessage.MessageLevel.StartGroup:
> > -                element.addStyleClass("console-group-title-level");
> > +        }
> > +        
> > +        if (this.type === WebInspector.ConsoleMessage.MessageType.StartGroup) {
> > +            element.addStyleClass("console-group-title");
> 
> Why can't this be in the switch liek before?
>

I only had one case to switch depending on "this.type" so I used an if
statement.

> What is up with the change to WebCore/workers/GenericWorkerTask.h? I don't
> think that is relivant to this change.

I added a type argument to "WorkerContext::addMessage"
then to "WorkerMessagingProxy::postConsoleMessageToWorkerObject"
then to "postConsoleMessageTask"

Then "createCallbackTask" needed an additional argument so I added
"GenericWorkerTask8".

Is this not necessary? I'm not sure when WorkerContext::addMessage gets called.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.