[Webkit-unassigned] [Bug 27103] Upstream V8NPObject.h and V8NPObject.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27103


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32488|review?                     |review-
               Flag|                            |




--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-07-09 12:54:35 PDT ---
(From update of attachment 32488)
Thanks for doing this! Just two minor style nits:

> +enum InvokeFunctionType {
> +    INVOKE_METHOD = 1,
> +    INVOKE_CONSTRUCT = 2,
> +    INVOKE_DEFAULT = 3
> +};

InvokeError, etc.

> +    return v8::Local<v8::Value>(); // Do not intercept the call.

return notHandledByInterceptor();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.